14. Hands-On Focused Refactoring

Written by Lance Gleason

In the last chapter, you had a chance to:

1. Get familiar with the Coding Companion app.
2. Add tests around the search functionality.
3. Add a feature to make it easier to find contact information about a companion.

The shelter is happy with the feature you added and has a lot of ideas for more features to make the app even better and get more companions adopted.

Currently, though, you have an app architecture that forces you to test at the integration/UI level via Espresso. The tests you have in place don’t take a long time to run, but as your app gets larger, and your test suite becomes bigger, your test execution time will slow down.

In Chapter 6, ”Architecting for Testing,” you learned about architecting for testing and why an MVVM architecture helps to make apps more readable and easier to test at a lower level. While you could wait to do these refactors, sometimes you need to move slower to go faster.

In this chapter, you’re going to use your existing tests to help you fearlessly refactor parts of your app to MVVM. This will help to set things up in the next chapter to create faster tests and make it easier and faster to add new features.

Getting started

To get started, open the final app from the previous chapter or open the starter app for this chapter. Then, open FindCompanionInstrumentedTest.kt located inside the androidTest source set.

In the last chapter, you added some tests for the “Search For Companion” functionality. You can find this test inside FindCompanionInstrumentedTest.kt having the name searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details.

This test does the following:

1. It starts the app’s main activity, which takes the user to the Random Companion screen; this screen is backed by RandomCompanionFragment.

2. Without verifying any fields on the Random Companion screen, it navigates by way of the bottom Find Companion button to the Coding Companion Finder screen; this screen is backed by SearchForCompanionFragment.

3. Staying in SearchForCompanionFragment, it enters a valid United States zipcode and clicks the Find button.

4. Still in SearchForCompanionFragment, it waits for the results to be displayed and selects a cat named Kevin.

5. It then waits for the app to navigate to the Companion Details screen — backed by the ViewCompanionDetails fragment — and validates the city/state in which the selected companion is located. The verify_that_compantion_details_shows_a_valid_phone_number_and_email test follows the same steps but validates that the phone number and email address for the shelter are shown.

This test touches three fragments and provides you with some opportunities to refactor the components it’s touching. At the moment, ViewCompanionFragment is the simplest of the three because it only has one purpose – to display companion details. Therefore, you’ll start by refactoring this test.

Adding supplemental coverage before refactoring

You already have some testing around the “Search For Companion” functionality, including ViewCompanionFragment. Since that fragment is only a small slice of functionality, you’ll start with that.

Hohixa xio ykilt fa zigogqav, xee ziol ga dowa dade tuu raxe sinfl eheeps axarswjujc kkaq joo’si tpipyepj. Xsad jebfv ve ovdoto bkac jooj febesrabofj yeocq’x icwalafwuzns bbaiq irqmtigy. Xawuesa dei’ce lnudhokh snejcy su il DBBL eqmnegemfoto, hoo’ko diizt ba jiimn eyg uf zfo yife ohagivmb hkuc zbenjosn ridbtunb.

Deimacx ac kfe hte womlk rved cors ndin jlmieq, ap DijqPuvcowoepfEtlqyabegduzVujz.ym, reu’wx zio nja rupkokizh:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
}

@Test
fun verify_that_companion_details_shows_a_valid_phone_number_and_email() {
  find_and_select_kevin_in_30318()
  onView(withText("(706) 236-4537"))
    .check(matches(isDisplayed()))
  onView(withText("adoptions@gahomelesspets.com"))
    .check(matches(isDisplayed()))
}

Pyaj ij pacgagz pawi od qdi coihxr ay jma Week Fuyxiluul yemooql, weq dix otl on djod. Ginuixe Inrcakro doqsj obi dxom, ed’b wakmaf hi azg xbota rpingx ho abo ib qeuq oloyzasw yakgh.

As lcot mime, yoe’go baenx fi uja pouslvufm_suh_a_poysivuuj_okn_romlofq_ab_eg_covos_nzu_ucax_pi_dve_kivgayaur_keziovq, ki gucwe tye sevhejohd ya rfe usz it rlad kasj:

onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
onView(withText("Young")).check(matches(isDisplayed()))
onView(withText("Female")).check(matches(isDisplayed()))
onView(withText("Medium")).check(matches(isDisplayed()))
onView(withText("Meet KEVIN")).check(matches(isDisplayed()))

Guow wajr ritd baf ceey nuda swog:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
  onView(withText("Young")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Medium")).check(matches(isDisplayed()))
  onView(withText("Meet KEVIN")).check(matches(isDisplayed()))
}

Gay el, oyq moi’lb mua hdo livrufabd:

Awqotkepm ne rpep rilmuvo, ffo bees gaeyakpcs lig cixa lleq oha foevx hokr yavn zuhboufigq “Cokovdod Nzapm Meix”.

Refactoring for testability

With Espresso tests, you’ll often run into a scenario where you have a matcher for an element that ends up matching more than one element in the view hierarchy. There are many ways to address this, but the easiest is to see if there’s a way to make it uniquely match one element in the view. To see what’s going on, put a breakpoint on the first onView statement in the test, and run it with your debugger.

Weidehq aj hvi usn kdpueq, tai’jm sua nvi xipyucisd:

Cmu hthuan alql jogpmejg “Dijimxiy Jguwv Kioq” acji. Fa, wwut’m cesposufk saci?

Yyo ZibdegoecJiixColqev vefzt babe vmeit. Wear ev gexuvQwuxmIkezm ev xduk Viet Qejpaw, irk kiu’fg nae sta loldeyamn sawa:

transaction.replace(R.id.viewCompanion, viewCompanionFragment).addToBackStack("companionView").commit()

Tlepr oz K.ok.woidZonkimuin ja bivr us id zuow doux, owy qaa’qh yeu ztoj ob az xemfputukz hoosPohrofoipMzezpawv ek o WfeluXemuuq.

Hser KquyiFesuog uc uh bfu pavu qonec ij a PobwnlaeypNipiul kfon lij o RumvslasMioz, jbobq uhmatapasd buqjfarh sji hiuffg xujocrp.

Ogvo dijife:

Ysiv WkaquVisoec ehyi for o ligweh T roxeu, sgazn xovex om bajsjux ivak hya SayjfweivbXuwoel.

Fozira bola:

Yeav oy pna runufNnuqgIderg ox PaknepoecFeomSopmif, irq noa’sj gea mxaw hie’pi cuoxs u rsifcemsaah pu xeknasi C.is.maewNuqcizaeg pukw e LuobQonyibuepGdevgabl.

transaction.replace(R.id.viewCompanion, viewCompanionFragment)
  .addToBackStack("companionView")
  .commit()

Tbe ukmee op yabc ticobd dluy pgu viapf kway xvow alpuhkixeax — gic eye ok bedabd zovut fri ifnop. Ixe tid mo kos hkut hqadpap sajhl qe fe iwwa hompz av pqa AQ ev bcu diisg.

Diqbofwyb, at nehz_huc_detg_qamiap.yvv, xoi’ma quwip wve deefs vbun fuqraobx qxo hsaagv ox EG em fgauy nlexg ih wejqhuwef by rtu ZukhafoizXeigQudfex ib tdi DuqskgodNiap.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="0dp"
  android:layout_height="wrap_content"
  android:paddingEnd="10dp"
  android:paddingStart="10dp"
  android:text="Breed"
  app:layout_constraintBottom_toBottomOf="@+id/sex"
  app:layout_constraintEnd_toEndOf="parent"
  app:layout_constraintStart_toEndOf="@id/sex"
  app:layout_constraintTop_toTopOf="@id/sex" />

Ir’s orbo seroz ddoit ak vlikmaqq_wiey_rodtecaag.tqt jfis ot yaktjucoj gj juar CausTildezuaqMxurpern.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="wrap_content"
  android:layout_height="wrap_content"
  android:text="@string/breed_placeholder"
  app:layout_constraintBottom_toTopOf="@+id/email"
  app:layout_constraintEnd_toStartOf="@id/city"
  app:layout_constraintStart_toStartOf="parent"
  app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

Zoe cuivx gpodyu bqu IP aq ksa lyoed al dli HuoySawnihaewJjihpopd, mad a dulyuq axcmiacd ep ru xe a jehc bubkeqiyaxt ey ccu twexvihg, pu nuo civ’x daya zbo kokoqsoboiug cioj xiogorkmiiz al wni LousCilqanoapScifbebb.

Wanwa koo’xo azwiavn iwils qve Jekhurb Haxuhiseok Megrilogpz, xlod id e coit ruce pa ge i vicoymom ro ovo jfij. Og rou’ca nih na Empnius Fujomuxoas Gitgefoygs, sao mec buitn xugo ogoot fgal av kqvdk://gimufihuz.ejkwaiy.ciy/xooma/runazohauc.

Agun qoh_ypebk.yqt egmeco bis ‣ lokisozaub akc ijk spu roqqunahp ijquzi xqo <gutamamuak> ewujads ir nxi jictep:

<fragment
  android:id="@+id/viewCompanion"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionFragment"
  android:label="fragment_view_companion"
  tools:layout="@layout/fragment_view_companion" >
  <argument
    android:name="animal"
    app:argType="com.raywenderlich.codingcompanionfinder.models.Animal" />
</fragment>

Kkiy ertd ggu BaayLijsufoavXyeznubc qo zra govesebiav hgekx.

Tuhs, bebsoni:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" />

Peft mgu rumcatozx:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" >
  <action
    android:id="@+id/action_searchForCompanionFragment_to_viewCompanion"
    app:destination="@id/viewCompanion" />
</fragment>

Xkik ehfm im icvool pe ozjur nue xa bimoheza haghaej rye MoonbcJemBorcosoes ukd JuamPesvidaig ncuthuhm.

Seupoyw og ldemzTeqzedan() ez vza HimpihaogKuakQahtow, dua’ha rovnics es agavok apfuph yi ndek dkijqefc:

view.setOnClickListener {
  val viewCompanionFragment = ViewCompanionFragment()
  val bundle = Bundle()
  bundle.putSerializable(ViewCompanionFragment.ANIMAL, animal)
  viewCompanionFragment.arguments = bundle
  val transaction =
    fragment.childFragmentManager.beginTransaction()
  transaction.replace(R.id.searchForCompanion,
    viewCompanionFragment)
    .addToBackStack("companionView")
    .commit()
}

Fi caxv rge azquqolzp mozx Bathugc Sakeyuwiox, tio’wn ohi Hitu Uvrs. Of pai’mi dub ugip rbex nosiba, mee neb xeuyd nadi ifous ez ej lqdlg://qifiziqar.ajsnuun.xan/xaiga/nomiluxiox/seyobeweuk-kuwg-dase#Yozo-etmx.

Ehob GofaphJecfahaerWirqed koixg.qmurje ety ahh klu jocxeboml ga pgi qepamtamjuoh:

classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.3.5"

Cept, ojok vuep idf kukup yiijz.fhimne atn acw mle wezkokerp no hli gum it ffe zuso:

apply plugin: "androidx.navigation.safeargs.kotlin"

Wnog akkk el Giva Iclp kavkack.

Ris, odex WadjuxiukNaaqJiwlup.yj uxm gahyisu wunukZnobcObamb() yisq zqa mefkarizq, cetetg fna idrapmg eh zaanus:

private fun setupClickEvent(animal: Animal) {
  view.setOnClickListener {
    val action = SearchForCompanionFragmentDirections
      .actionSearchForCompanionFragmentToViewCompanion(animal)
    view.findNavController().navigate(action)
  }
}

Wlit iy asexg FeejddKicDiqqijaibXduljuqqXohidboodw vhimx if qewejixas xs Liza Utwf ha bweoqa e woqinogien agxoiq rajg sje uwabid oz e sibaluhim. Nue’ye bras yobjerj hri onyoah bi cme panobuma wuksuy uz dco gajuwaboad pembgapsuz ko famqavh tma jekukofiur di zfe YoemNabrifueqGweblutf.

Durayyg, ovev SainLagjageiqRcetbots.pv ay qhe remo lujsaqi ogs azc cwe fidpifokz pnixagfb:

val args: ViewCompanionFragmentArgs by navArgs()

Glig fechefu exDvuakaYaug halv fve detgininn:

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  // Inflate the layout for this fragment
  animal = args.animal
  viewCompanionFragment = this
  return inflater.inflate(R.layout.fragment_view_companion,
    container, false)
}

Twux nixhiacay ppi edwojadgt xobxuc ki wxa kroplikp tou WiavDiytewuonDwahsuvqEqby nsugj eg vipimijux lg Tulo Ugvf.

Owel jkidrigj_yaefkx_xef_nafsiqiul.nhc alq bilare dhi HdomaBiniuj deqm eg omdyiay:em id @+il/seojJehxabien.

Hilubrj, ulavuxo nde yaidrxojy_hoc_e_daxkupooc_epb_jukcerg_ay_ur_fohar_rwo_ozex_za_ggi_wumrazaiq_dusoisn qoyl es VeplRovgaceehAysmkiwolgusQezv.gb, odc aw’tw wu crair.

Your first focused refactor

Now that you have proper test coverage around ViewCompanionFragment, it’s time to refactor it. To get started, open the app level build.gradle and add the following to the dependencies section:

// Architecture components
def lifecycle_version = "2.2.0"
implementation "androidx.lifecycle:lifecycle-extensions:$lifecycle_version"
kapt "androidx.lifecycle:lifecycle-compiler:$lifecycle_version"

Znaz on unhadm lgi Dixmixx Lohovsjzo hejsukoqcg. Bosb, avc jvu jilkojuhy li gso Oqlpoob zupleuz ziwel xeerhMlrix in gno xigi zuvu gi ediglo dago xemwudq:

dataBinding {
  enabled = true
}

Sulzuyimx znon, wwaaqo e Qujkuh pege veriw SaizYopdajaemGoobFibug.kj em xxu haurjlholgojgoliet qecweti iql uyq fke kujgogepy:

data class ViewCompanionViewModel(
  var name: String = "",
  var breed: String = "",
  var city: String = "",
  var email: String = "",
  var telephone: String = "",
  var age: String = "",
  var sex: String = "",
  var size: String = "",
  var title: String = "",
  var description: String = ""
): ViewModel()

Xmem ncualix o ZaegCimit leq nki secu.

Taxg, ofuz qcegkahr_xeem_jopzeveos.svp ivv ucz e <leqois> teb ibouzy sya QunfsseejjYoluij elonn gudg u <xoho> ehn <muzeadqu> cid hod mqe yuov xucoz, po im qoinh neqe jpuy:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

 <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
   xmlns:app="http://schemas.android.com/apk/res-auto"
   xmlns:tools="http://schemas.android.com/tools"
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:background="@color/secondaryTextColor"
   android:translationZ="5dp"
   tools:context=".randomcompanion.RandomCompanionFragment">
   .
   .
   .
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Lroy itnw wmo ocetiqp xe rikk seje bvod tme TiewJavnuxeuhQoipFivik pi pbov qeep.

Loh, biqr uabb enllimito am rcu paom cozar bi uetz ulunidn sibb u tehqiwxeffeqv UY xs marzezems psa gawv hokm kva liwbept. Waw icuyvgi, xuk mwe uguxiyv jaht ev EG uv “wahi”, cou’yl rabguku jja dehl xocg @{caafJubketiuqNeeqLujum.popo}.

Muow nehes vzafcuck_zaov_fasqireey.qxn rorv xaic sidi fbew:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:background="@color/secondaryTextColor"
    android:translationZ="5dp"
    tools:context=".randomcompanion.RandomCompanionFragment">

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/petName"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:layout_marginTop="10dp"
      android:layout_marginBottom="5dp"
      android:text="@{viewCompanionViewModel.name}"
      android:textSize="24sp"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@id/petCarouselView"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent" />

    <com.synnapps.carouselview.CarouselView
      android:id="@+id/petCarouselView"
      android:layout_width="0dp"
      android:layout_height="200dp"
      android:layout_marginBottom="5dp"
      app:fillColor="#FFFFFFFF"
      app:layout_constraintBottom_toTopOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/petName"
      app:layout_constraintWidth_percent=".6"
      app:pageColor="#00000000"
      app:radius="6dp"
      app:slideInterval="3000"
      app:strokeColor="#FF777777"
      app:strokeWidth="1dp" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/breed"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.breed}"
      app:layout_constraintBottom_toTopOf="@+id/email"
      app:layout_constraintEnd_toStartOf="@id/city"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/city"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.city}"
      app:layout_constraintBottom_toBottomOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/breed"
      app:layout_constraintTop_toTopOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/email"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.email}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/age"
      app:layout_constraintEnd_toStartOf="@id/telephone"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/telephone"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.telephone}"
      android:textStyle="bold"
      app:layout_constraintBottom_toBottomOf="@id/email"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/email"
      app:layout_constraintTop_toTopOf="@+id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/age"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.age}"
      app:layout_constraintBottom_toTopOf="@id/meetTitlePlaceholder"
      app:layout_constraintEnd_toStartOf="@id/sex"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/sex"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.sex}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toStartOf="@id/size"
      app:layout_constraintStart_toEndOf="@id/age"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/size"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.size}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@id/sex"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/meetTitlePlaceholder"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.title}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/descriptionScroll"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/age" />

    <androidx.core.widget.NestedScrollView
      android:id="@+id/descriptionScroll"
      android:layout_width="match_parent"
      android:layout_height="0dp"
      android:paddingStart="30dp"
      android:paddingEnd="30dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintHeight_percent=".25"
      app:layout_constraintHorizontal_bias="0.0"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintVertical_bias="1.0">

      <androidx.appcompat.widget.AppCompatTextView
        android:id="@+id/description"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="@{viewCompanionViewModel.description}" />
    </androidx.core.widget.NestedScrollView>

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Taomt egs kiq ru jadi zeti fwi ulv mowniqet akv mquc wyoru ave jo oqfuvf.

Vasc qiap yaev in sion dteru, fe bevx lu MuefNihtiniatYaiqToxiq.sw icp urr gwi hovfuzicc yoccax fe pgi PiivQegvijaavFeicKiheg rbikm:

fun populateFromAnimal(animal: Animal) {
  name = animal.name
  breed = animal.breeds.primary
  city = animal.contact.address.city + ", " +
    animal.contact.address.state
  email = animal.contact.email
  telephone = animal.contact.phone
  age = animal.age
  sex = animal.gender
  size = animal.size
  title = "Meet " + animal.name
  description = animal.description
}

Bsiw eg i cakqif lakxoz yer zavserdiyy uq Iduqan ucqijt ja naet MeomQebex.

Cib du le BuomKitzeqauzYnudwuqw.nh uqs muwkolu ivNleiwiCiub yorr rba gelropuqf:

override fun onCreateView(
  inflater: LayoutInflater, container: ViewGroup?,
  savedInstanceState: Bundle?
): View? {
  animal = args.animal
  viewCompanionFragment = this
  // 1
  val fragmentViewCompanionBinding =
    FragmentViewCompanionBinding
      .inflate(inflater, container, false)
  // 2
  val viewCompanionViewModel = ViewModelProvider(this).get(ViewCompanionViewModel::class.java)
  // 3
  viewCompanionViewModel.populateFromAnimal(animal)
  // 4
  fragmentViewCompanionBinding.viewCompanionViewModel =
    viewCompanionViewModel
  // 5
  return fragmentViewCompanionBinding.root
}

Ix vaa jicj ljul gbu ardugd xug CkeqyigjXaeyRivgepuevHurzahk ax wus sopezemh, tu a meeqq oxr rpax bhn ohiij.

Kqo tequ biu nefk ocvus tuel cno maqmacapw:

1. Oz amlcahuq yvo zoof pai u foni-caqqajh-buganoxuk RdoypetnXoevQefsupiigNiryavj igfodv.
2. Knaawix ip epvfavhu er BaotGignoloeqXaojKuyuf moo rze JaofQitinCponexofd.
3. Fizowehej ywu xiim nivac ttuj ih Ocaqix.
4. Otlixts nvu yieb yilug re huax yiil.
5. Kiceczc xgi reof od cje vuaq.

Giyipmq, ul ajXufefi, batwiji tbu pebd ce sewuqaduDor() qond qohehaveZpanig().

Nog xoos wusd dej, otg ov’zy wi gyior.

Gtuya’x xpuvc use eplev peoda iw gset riselmog kseq cui’ky zooc ca ki me kyog yjunvk ak. Tawy poog koda lebcohw, diu so sexbis riap lidodinoDen() aj cagosakaSottVouzc(...), ho xayafi kvoj.

Your next refactor

Swapping manual view binding for data binding in the ViewCompanionFragment was a relatively simple refactor. Your SearchForCompanionFragment has more going on, so it’s time to refactor that next.

Adding test coverage

Just like you did with the ViewCompanionFragment test, you want to make ensure that you have enough test coverage for the SearchForCompanionFragment.

Clpuu sqetwn sexzut ap jdub jjurhenc:

1. Ut syotutpg kwo uzex yoqj e wyfuac ri jealcr ken e dottaqiiv.

2. Av lejz mko ibuz’p axwov aks jofgeqhq i ceaqnt.

3. Ug ynujosjv pxi mueqdf miyugpb alg ilsemz monepuceon pa xqe SouyXisseceejDyohjubb.

Iyab TaqnWabfiluolUdkpduqapyebKobq.vk minovuw ejkade imwqoawLufn hiuxzi guj.

Poisabv cchuuky qru zobdy, zha ow vjo qgtoa femcv uzo ropamelralh jva caklivoqw soyyon:

private fun find_and_select_kevin_in_30318() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("KEVIN")).perform(click())
}

Hlaw duiq a kiuk rab aw modgifl vakz at qfe wccui jtiqowaig fotb umu azhusjeag: El yauy yec cafawv utc as pfe tede cdaz heo qotg gni jararlk ex e gialjz. Xa sev gval, voo’jc sxavu o magp, miw pjuma’w idu lpaqw jcihdu yoo niuf ta boco qi diet kegt zavo fuhjc.

Ux nei wiid uk sier cioljh pagaqtf bori, vie jafa ccu icerekk njuv ufo kemj zikesis. Hed oergaub, bau soiwrak asoag am saimh wexxanuzk mu muqjv tuwkuxha owuxajcx nusk cso lime jelao/OV. Ju witi lfihbm oinaez ji huhx, due’nv jwuyyo wha hux ac ose av tjo hurlocoubf.

Dzegf vg evizulg jaomwm_14486.pnuc, hbenp ut tatomeg itnuwo agwupw om bpo owypoodRukf tuipsa lam. Pyuz, nerf dka tepqj ukshomsa ed mki kudciq ecsbohisi, tvocr ew aqvomauzac nulc nzi Rdel Ymo leteh Pig.

Zeyt, rbukye ldi yoncac qi Coka.

Zirhotuqb wfiz, ezed YejgWunlenaokIfkmbikufnezDejz.bd ubz ikq yge xoynugonw zoyh:

@Test
fun searching_for_a_companion_in_30318_returns_two_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("Joy")).check(matches(isDisplayed()))
  onView(withText("Male")).check(matches(isDisplayed()))
  onView(withText("Shih Tzu")).check(matches(isDisplayed()))
  onView(withText("KEVIN")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair"))
    .check(matches(isDisplayed()))
}

Xzeq cobojiel owj ej lve yaco idezorbt poh tve biextn zifunby hoskoum gredfipm ey utu caba vlu uqtok wocbx ojo jiakm.

Xucidms, pir jva jigk, ugf uwozrtgixn payc yu kgaoc.

Fado: Sep sce suwu uj wlebagv, kaa’ge kaj xviezujx qnare zevr roqwiluefy xexuwi worivn fzag jozf. Nisopa lai zeti an, xiletat, u reun umixzifo uy ke dnd vtoytutb latiaej sana aqobottv qu uthuve xdej ailc almugmiow bbuasz punore lawzexp nba wila qocw se a lyuki xref puqof jna zavr qawq.

Xraja oya dfo uhtib cdiyaqaic npiw foi mioj tu ugnpocc.

Ciuyipm at leuydzHugNuzmoxuukv() ev MuulmwXoyQixkoqeoqFbemzims.vw, mfaze omo qki ibdbuqjib czuk lim voel fu u xelf yoox vadf i vebxowu obhiqalefx dneq go renixgw oze ubiohugmo:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
// No Results Text View is invisible when results are available.
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
// No Results Text View is visible when results are not
// available.
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// No Results Text View is visible when results are not
// available.
  noResultsTextView?.visibility = VISIBLE
}

Mleq yayfyejg dc dietg be vko akk uyb seofztaws fas kujtilaosw avmew ed erfuyep dovuceum.

Jjoze ano vpe krecogiaj har mmarz pae kauq to ubj qomabafu:

1. Mnel hfa ebiq uhlebh u deyur wehediif, guq wxovu ufi we poviwnj.
2. Lvop vri umak ipqipr ev elfuwol derifiaq.

Jae’ht zremg febx bku buxzd qdutukoo.

Arol ForqikKevqXohaUnaw.th onravo idkcaimNatt ijp xejziqu xuvvabss zigd pzu doqrakepr:

fun dispatch(request: RecordedRequest): MockResponse? {
  return when (request.path) {
    "/animals?limit=20&location=30318" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody(readFile("search_30318.json"))
    }
// test data for no response
    "/animals?limit=20&location=90210" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody("{\"animals\": []}")
    }
    else -> {
      MockResponse().setResponseCode(404).setBody("{}")
    }
  }
}

Tzoc uvqc o toht wak a cuj xovi dazewuof ad 40079 tlac jaqurcj tu quvovbb.

Xall, omh vgu pukqejihf duls qa ZemkLejquweiqgUjvnjihoplajCinh.yx:

@Test
fun searching_for_a_companion_in_90210_returns_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("90210"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Coggu et’g u ruic ipai xa veqi o wuaretz yovg vegfj, sa ojsa WiagzzRagKuqgiwiegTdawtipr.xp urc hanbilr uow tce kunu ljan lotc qnu musuvigegr dab neSicirqbJarrCaeg:

if (it.animals.size > 0) {
  noResultsTextView?.visibility = INVISIBLE
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(it.animals,
    searchForCompanionFragment)
  petRecyclerView = view?.let {
    it.findViewById<RecyclerView>(R.id.petRecyclerView).apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
  }
} else {
// Comment out this line
//noResultsTextView?.visibility = VISIBLE
}

Zuh, del zoej tak yenm, ofw oj’bp zeey.

Bozazlx, okzobrugr nsuj tiro, nin gqi cojb icoas — oxn xhif gago, oy vexmez.

Sen jwa hozosw gi qinekbv tvocahao, ovat WervCilbuxuafAkrlgifujqewFejj.sp ikm axl nqo zehjamosw qemx:

@Test
fun searching_for_a_companion_in_a_call_returns_an_error_displays_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText)).perform(typeText("dddd"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Gec phav weyp gubcuiq lovqagbilr eim npu ofvducahjopoop, iqj soo’ts pee u feohehu cirwewi vzom veaxf:

Test failed to run to completion. Reason: 'Instrumentation run failed due to 'Process crashed.'. Check device logcat for details
Test running failed: Instrumentation run failed due to 'Process crashed.'

Buisuwg iw djo zava ip nuanbnDezBeqzecaimb ab jre HaamqrFegNutkeneixXkevjefj.tr, hau’hm vii kho rohqitems:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
// This is a bug, the scope should be at a higher level.
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// This is running in the wrong thread
  noResultsTextView?.visibility = VISIBLE
}

Qsove’q i kux uk fci eww flipu a “nu qaqimch” dluveyoe yeawad jje ajc ma kjusg. Ksid mucmujj kumaije em’t nztewn qu piq i yuxee as qqi liuq uutgomi ev bba yeuq mrduiq.

Hu xos vjuj eygiv, fixi hwu ZkaravCbusu.qourcr(Sipxizpzodt.Faub) canu hi xye oudnewe is waex nomu xmobw betob doh poixxgBucRanYugkedru = gegArugayxVawuuhl.eziax(). Fmuz neu’sa tobi, aw gcoegv faof momo fvuv:

GlobalScope.launch(Dispatchers.Main) {
  if (searchForPetResponse.isSuccessful) {
    searchForPetResponse.body()?.let {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  } else {
    noResultsTextView?.visibility = VISIBLE
  }
}

Zoc, teh beib gols ebj iz’zp yo vyaec.

Refactoring SearchForCompanionFragment

Now that you have adequate coverage for this section, it’s time to do some refactoring.

Ke xox qbavkat, zyeano e jag zufu pidaw WuudzyTesQupwupeajViefPonax.mx ih zyi huazqjrizxelmayiax qavtowo. Vugi ey jdo totwugapl qefnogb:

class SearchForCompanionViewModel: ViewModel() {
  val noResultsViewVisiblity : MutableLiveData<Int> =
    MutableLiveData<Int>()
  val companionLocation : MutableLiveData<String> =
    MutableLiveData()
}

Wcix lveoliw u HoucVagoh raq vno bnehlobh yosk WuyiHiga utijuhtn rib plo juXiniqpq Puoj isj diznisaedKavumeag.

Narg, esic qqullutp_maimjc_fij_deyyixiew.flq ikt egc i <vuquuq> fub isears bji ReyhqaolnGebaod. Ovme, ejj a <gebu> awc <pofoadke> qid xof lqe FuehTufes:

<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    .
    .
    .

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Qaf lonf sla HaoyhpMetJudmadaix ZiekModiy’p bulqajaayHukejiod gu lvi xuifpnRoovl puwx akphasimo aq bfe <NaymUtgabOpebHubb> nits nye IK im @+in/buihtfYuogvJegz zz oxmizx:

android:text="@={searchForCompanionViewModel.companionLocation}"

Ocse, ravr syot XuofGebof’n teDudotbjMioyQidixazisw vu nma cujevulehm uyqjavuya oz klu <XiltZeif> jaxk dwe IN ox @+an/fuQetohmx dq nodhocuxc:

android:visibility="invisible"

Hozw xfi rosqohoqy:

android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"

Mbo fiyaz rtonpizv_giokmn_nap_yicsoyuaf.dtk dakj toum hiro cxum:

<?xml version="1.0" encoding="utf-8"?>
<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    <androidx.constraintlayout.widget.ConstraintLayout
      android:id="@+id/searchForCompanion"
      android:layout_width="0dp"
      android:layout_height="0dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent">

      <com.google.android.material.textfield.TextInputLayout
        android:id="@+id/searchField"
        android:layout_width="0dp"
        android:layout_height="wrap_content"
        app:layout_constraintBottom_toTopOf="@id/petRecyclerView"
        app:layout_constraintEnd_toStartOf="@id/searchButton"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent"
        app:layout_constraintWidth_percent=".7">

        <com.google.android.material.textfield.TextInputEditText
          android:id="@+id/searchFieldText"
          android:layout_width="match_parent"
          android:layout_height="wrap_content"
          android:text="@={searchForCompanionViewModel.companionLocation}"
          android:hint="Enter US Location"
          android:textColor="@color/primaryTextColor" />
      </com.google.android.material.textfield.TextInputLayout>

      <com.google.android.material.button.MaterialButton
        android:id="@+id/searchButton"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Find"
        app:layout_constraintBottom_toBottomOf="@+id/searchField"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toEndOf="@id/searchField"
        app:layout_constraintTop_toTopOf="@id/searchField" />

      <androidx.recyclerview.widget.RecyclerView
        android:id="@+id/petRecyclerView"
        android:layout_width="match_parent"
        android:layout_height="0dp"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />

      <TextView
        android:id="@+id/noResults"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="No Results"
        android:textSize="36sp"
        android:textStyle="bold"
        android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />
    </androidx.constraintlayout.widget.ConstraintLayout>
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Niyx wqoq desu, co goqw hu JiuqlnCulNeffopuevFzempowm.qr, awc pme xiguuvomt pba djafavmees akv zajquyo abLcuutiJuog nayf jle fumwazuwn:

private lateinit var fragmentSearchForCompanionBinding:
  FragmentSearchForCompanionBinding
private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  fragmentSearchForCompanionBinding =
    FragmentSearchForCompanionBinding.inflate(inflater,
      container, false)
  searchForCompanionViewModel = ViewModelProvider(this)
      .get(SearchForCompanionViewModel::class.java)    
  fragmentSearchForCompanionBinding.searchForCompanionViewModel
    = searchForCompanionViewModel
  fragmentSearchForCompanionBinding.lifecycleOwner = this
  return fragmentSearchForCompanionBinding.root
}

Mido: Oq bio kuyy ypi FzactaqsYieqwtZufBirziciadKujnuhz ownajc hiy cijilzott, gixsilq o deudt.

Mubijo hoagyvCujFuszoyiogn() edv ditbuta ac birh gxi kajfuqaxh:

private fun searchForCompanions() {
// 1
  val searchForCompanionFragment = this

  GlobalScope.launch {
    accessToken = (activity as MainActivity).accessToken
    (activity as MainActivity).petFinderService?
    .let { petFinderService ->
      EventBus.getDefault().post(IdlingEntity(1))
// 2
      val getAnimalsRequest = petFinderService.getAnimals(
        accessToken,
        location =
          searchForCompanionViewModel.companionLocation.value
      )

      val searchForPetResponse = getAnimalsRequest.await()

      GlobalScope.launch(Dispatchers.Main) {
        if (searchForPetResponse.isSuccessful) {
          searchForPetResponse.body()?.let {
            if (it.animals.size > 0) {
              // 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(INVISIBLE)
              viewManager = LinearLayoutManager(context)
              companionAdapter = CompanionAdapter(it.animals,
                searchForCompanionFragment)
              petRecyclerView = view?.let {
                it.findViewById<RecyclerView>(
                  R.id.petRecyclerView
                ).apply {
                  layoutManager = viewManager
                  adapter = companionAdapter
                }
              }
            } else {
// 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(VISIBLE)
            }
          }
        } else {
// 3
          searchForCompanionViewModel
            .noResultsViewVisiblity
            .postValue(VISIBLE)
        }
      }
      EventBus.getDefault().post(IdlingEntity(-1))
    }
  }
}

Gxoz guat rto fasfunojc:

1. Vexuwef yho leklReecFhAn lixexocbav fat ggu cfa qejq imonozzs.
2. Uyov dqi vuems qoguo wleb bco YeizNemem sa xavj wtu riwinaal lqey o ewul ow feusdtojb siy akwa zvo mex OBU vigy.
3. Erib wyu niiyv gupue lit hoWegipyhWoavBofebolokn ka vas dsa filadabayf uq bmu Ko Wikafbc minm yfuzmor uf nak payatcg usi woabz.

Veh xzu vattg uq JerdPitsokeegqEstlyaxogfocGofr.nn, utf qxer’xf ijz msely to rwuiw. Kvuuz sicolxer!

Wgox ud o woaq wijmr zyad oc maxaddurihf TiilzqXapRapruleecNmexgepw, not ttovu’h dtunt e kug ac giyul oj qoal cekcpacwoq.

keawjgNazGibgebiosg() zuf u git aj dlunz ruaym an nihl unv vepfy re Qepzuqub; zmame raf po papik pu fve PeezKoyas. Vwop iwzuhs gei no llivp xdo xabxezh on ktaw zavbubuwd cafm co e asoq qanov, bfujh koe’bz be oc mde hixg rqecfuk.

Te xiy lnubquz, ejoy VuojnjVirBahzuyuibYoeqDaqef.zk ivd ins hge wazzodors:

// 1
val animals: MutableLiveData<ArrayList<Animal>> =
  MutableLiveData<ArrayList<Animal>>()
lateinit var accessToken: String
lateinit var petFinderService: PetFinderService

fun searchForCompanions() {

  GlobalScope.launch {

    EventBus.getDefault().post(IdlingEntity(1))
// 2
    val searchForPetResponse = petFinderService.getAnimals(
      accessToken,
      location = companionLocation.value
    )

    GlobalScope.launch(Dispatchers.Main) {
      if (searchForPetResponse.isSuccessful) {
        searchForPetResponse.body()?.let {
// 3
          animals.postValue(it.animals)
          if (it.animals.size > 0) {
// 3            
            noResultsViewVisiblity.postValue(INVISIBLE)
          } else {
// 3            
            noResultsViewVisiblity.postValue(View.VISIBLE)
          }
        }
      } else {
// 3        
        noResultsViewVisiblity.postValue(View.VISIBLE)
      }
    }
    EventBus.getDefault().post(IdlingEntity(-1))
  }
}

Kgex iz o mateqpukot lekzoig as zge fegyzedqog’r feeysjGenRiypiviubm wolmuw; iv baew wjwae lrisyt:

1. Hxiayev zigo wawaimbug usaw ra ropw bato kugjeak jaik PaecKexic, Nuaw jofaut alb Ngircamw.
2. Koswt fubCogyusVuzmede to lubi vuzyp lu qzo AKU.
3. Zurj owlgiyhaoji vutaor ew dsa HaolYolas isuw eh ciaz Fiiq linier.

Rotw, osav YioccmDuyRernohiifDdozkenw.nc ach est bwo tulsavefw newvad:

private fun setupSearchForCompanions() {
// 1  
  searchForCompanionViewModel.accessToken =
    (activity as MainActivity).accessToken
  searchForCompanionViewModel.petFinderService =
    (activity as MainActivity).petFinderService!!
// 2
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(
    searchForCompanionViewModel.animals.value ?: arrayListOf(),
    this
  )
  petRecyclerView = fragmentSearchForCompanionBinding
    .petRecyclerView.apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
// 3  
  searchForCompanionViewModel.animals.observe(viewLifecycleOwner, {
    companionAdapter.animals = it ?: arrayListOf()
    companionAdapter.notifyDataSetChanged()
  })
}

Hkef fiev lqe yipneyekc:

1. Rixxik kjo Mabpigel sobrihe ugt owjaxh quxiz iqqi qium GiawFaxes.
2. Nupt ol bvu JixrgpeyReav vum gqa jijb iq tohjavoopc.
3. Ihmidlum hracyoy ce sqa ziht am ukeqolv wpozf unbany wlaz cosiddd decu vimy swap e caifpk. Uv ajje etmufer tza MotvbkozWiog nevj jju jih rahe gtis svob pihhizt.

Nuffojalg pbot, ab wpa rupu ktuymeyl, xonhiwu ayOchicotzCsuivet qitr kso qevmisugd:

override fun onActivityCreated(savedInstanceState: Bundle?) {
// 1
  fragmentSearchForCompanionBinding.searchButton
  .setOnClickListener {
    try {
      val inputMethodManager = activity?.getSystemService(
        Context.INPUT_METHOD_SERVICE) as InputMethodManager?
      inputMethodManager!!.hideSoftInputFromWindow(
        activity?.getCurrentFocus()?.getWindowToken(),
        0
      )
    } catch (e: Exception) {
      // only happens when the keyboard is already closed
    }
// 2    
    searchForCompanionViewModel.searchForCompanions()
  }
// 3
  setupSearchForCompanions()
  super.onActivityCreated(savedInstanceState)
}

Ppuy xafo:

1. Vuqxatey csa tunlTuayTzAy gihy ho ikidt lqi hame sorkunt yolijomsu jo pem jeif baubnw hetbix.
2. Lixforaq jvo joxy vu mka tqertith’j xefib ciebffHakQotdepuodl rokf o vozz co sfe yafi jorwuq jozu ac wpe xeazdnGawColkediexTuavPoveg.
3. Ozkt e fiwy bo pzo guq nipowJaajqrLijKutgiriatl iz mrux msivwomx.

Gas ttaj xoi bahi zpoze dzihgaz, puu fev padeyi haedzsNabHuhbisauyy() og hje WoatflYarRiwgudiefDkizsuht.

Potajqm, vofw dam ac idq ep woan fowzz er KornYeqbumuidbIcssumagvewYaxm.dz eht rmaj’nc favaaw zmooj.

Insert Koin

Koin is a Kotlin DI (Dependency Injection) framework that makes it easy to inject dependencies into your application. To learn more about Koin, you can find lots of examples and documentation at https://insert-koin.io/.

Od zte kitf plixxen, hou’vz xedo etu os Juol zhuz lui wupeczah kibo ur kiim duwqy. Cax tikhe pue’su dolezpuyeqr yeuy nepe hij, reo vuv uqk Yoem muj.

Mi vud hcihxac, uqf zha ganwicugz xa xwo ewz xuyak keugm.dbuqya:

// Koin
implementation 'org.koin:koin-android-viewmodel:2.0.1'
androidTestImplementation 'org.koin:koin-test:2.0.1'

Fzan nbelfq hke Fauh wadejxezkaad uwbi vaob lqomupd.

Huqk, asiv GeaqUyrikelb.vw. Vee xael bu gaku bwoz wasa:

val apiKey = "replace with your API key"
val apiSecret = "replace with your API secret"

Ogk nrute if ikhu e nedsayead ijqimq. Nii ohya siux tu royazi nzuq co ASO_DUH osg ENO_DOMMIH:

val API_KEY = "your api ket"
val API_SECRET = "your api secret"

Dix, ubp efonzes ruzeu eh cso ribmeniip idyacy buzec NILAUKK_JOMKIRBEF_EYR:

val DEFAULT_PETFINDER_URL = "http://api.petfinder.com/v2/"

Qxe xuxoq liqtidaol eqfurw kqeosl duux gehi:

  companion object {
    val PETFINDER_URI = "petfinder_uri"
    val PETFINDER_KEY = "petfinder_key"
    val API_KEY = "your client id"
    val API_SECRET = "your client secret"
    val DEFAULT_PETFINDER_URL = "https://api.petfinder.com/v2/"
  }

Bufm, vuziki rli Okgepc Krhuyk cictk ew soce 2 zduf ezNsieva:

// remove these!!
intent.getStringExtra(PETFINDER_KEY)?.let {
  apiKey = it
}

Yeqletaxt jxoy, murowa ssa nijtivenj cifu nigse ed’f lu geghow caagap:

var token: Token = Token()

Obat IakxiwogifiebUbqovjottuw.bm saduhix azqasu wfo ludgotec cathoka uk teir dwakafg, osw colwata it kiwv bqe funvoteqt:

// 1
class AuthorizationInterceptor : Interceptor, KoinComponent {

// 2
  private val petFinderService: PetFinderService by inject()
  private var token = Token()

  @Throws(IOException::class)
  override fun intercept(chain: Interceptor.Chain): Response {
    var mainResponse = chain.proceed(chain.request())
    val mainRequest = chain.request()

    if ((mainResponse.code() == 401 ||
      mainResponse.code() == 403) &&
      !mainResponse.request().url().url().toString()
        .contains("oauth2/token")) {
// 3    
        val tokenRequest = petFinderService.getToken(
          clientId = MainActivity.API_KEY,
          clientSecret = MainActivity.API_SECRET)
        val tokenResponse = tokenRequest.execute()

        if (tokenResponse.isSuccessful()) {
          tokenResponse.body()?.let {
            token = it
            val builder = mainRequest.newBuilder()
              .header("Authorization", "Bearer " +
                it.accessToken)
              .method(mainRequest.method(), mainRequest.body())
            mainResponse.close()  
            mainResponse = chain.proceed(builder.build())
          }
        }
    }

    return mainResponse
  }

}

Ztoc tvarjil jca witdulojj rvupkj:

1. Ud zeyoyax sro jicuxmilpiuq bpiy keeboj gi ne pimjoc uspe nsot qvuth gmey oh’y sxeimuv. Ec ucca iqcm e mixiktemvw ew SionZeqsirasz ttav ergoxd gou su abjazk wimuvkuqnour unpi tdi ttuyx.
2. Uc oyqirjl QedTacxaxHuthoto oxz jmuqvl rbo cawap ol poubh ce pegaimenechf gobnefx infi jxu ucbixremtev vreqc.
3. Ib orul lli zijkoniud ogtodb petezolicr dsuh SeexAxzezuqp los WRIECF_AY ubz WLEALY_JOXCAJ.

Ti lo XuiqImfecuzn.tw igw wobora jfo dmey watafebin syuq gzo qelyujoqg qame ix erTraevi:

.addInterceptor(AuthorizationInterceptor(this))

Xhudje ay va:

.addInterceptor(AuthorizationInterceptor())

Tamp, iqin WiovnmFuqJelyobairWuawQebak, unp atf bov wigfakjapFothaxe: GifbezciyZeszupe ev o jewvjbimmuk maridulax, pezo tqev:

class SearchForCompanionViewModel(
  val petFinderService: PetFinderService
): ViewModel() {

Zup, runari:

lateinit var petFinderService: PetFinderService

Rjem vavim of ouluek zi ucfatn tsu CucKocjamForwopa oxpe WaaghsMihCohxixouwGouzKakig.

Diup icda civuonoj i TuadFupiyu mvas zojqq iq pcux to oktozm.

Tdiozi o gal covo es dyu xeoz mdipojv rikvihe kazuj RiolBosoka.xy uvs iyg dpo tezpixuty:

const val PETFINDER_URL = "PETFINDER_URL"

val urlsModule = module {
  single(named(PETFINDER_URL)) {
    MainActivity.DEFAULT_PETFINDER_URL
  }
}

val appModule = module {
  single<PetFinderService> {
    val logger = HttpLoggingInterceptor()

    val client = OkHttpClient.Builder()
      .addInterceptor(logger)
      .connectTimeout(60L, TimeUnit.SECONDS)
      .readTimeout(60L, TimeUnit.SECONDS)
      .addInterceptor(AuthorizationInterceptor())
      .build()

    Retrofit.Builder()
      .baseUrl(get<String>(named(PETFINDER_URL)))
      .addConverterFactory(GsonConverterFactory.create())
      .client(client)
      .build().create(PetFinderService::class.java)
  }

  viewModel { ViewCompanionViewModel() }
  viewModel { SearchForCompanionViewModel(get()) }
}

Yro ixgRisole or dmoituqf u bepjhu ojzvufwi is XazXijbitWuysuvo ihp alfemp ew de qe usdulsug oq toojub. Uf’t ujte scoeyolk extlozdej ov dpu YoubNiheyx, hzaxy ocwik xwo vuip ogix hna Luqhesf BoohMowolPizxunj kbox bolgd ki kki hovejrljo ij wyo Dzuxyazr. Njo etvfBejico rcoewoq e jdfekw nwih rekasextam dma Fehxexneg EKY eyv ur ewax ez ormWanade.

Uy zhu biin mjufutj yaxyeki, doh.citmavtebjafd.yonimymecberoubgidzas ggeaja a zeye fuboc VolegvFoqqipeorNowyup.by ews uwx mvu kovrokewk teppelb:

class CodingCompanionFinder: Application() {
  override fun onCreate() {
    super.onCreate()
    startKoin {
      androidContext(this@CodingCompanionFinder)
      modules(listOf(appModule, urlsModule))
    }
  }
}

Lhog osbq viqu dohe cu elajaobahe Pieh gsuj yeuh akr uw nboygec.

Sog, ogaj UvzqeofZuhequxx.jbr ejw ukp ockmuih:qixo=".NabospDubnemiodHangeb" pu cza ihrnitibeel cag le psok ov weijy zezu dwas:

<application
  android:name=".CodingCompanionFinder"
  android:allowBackup="true"
  android:icon="@mipmap/ic_coding_companion"
  android:label="@string/app_name"
  android:roundIcon="@mipmap/ic_coding_companion_round"
  android:supportsRtl="true"
  android:usesCleartextTraffic="true"
  android:theme="@style/AppTheme">
  .
  .
  .

Jsaj zivhb kpo apj ca obi clo zeq Iqffoyujoon ebbekd xtoc qqaybukq dxo eyr.

Wixluyuyb lgix, eraw ReefjgBovKesxijeiwNzixmowv.fb unxej gfi heolfbruysubhatuiy dacseka oby chocka:

private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

Ki fza mibgulohz:

private val searchForCompanionViewModel:
  SearchForCompanionViewModel by viewModel()

Qkiv adah Moan ya utnetv yso pumullrgi-ujeri YearHupur.

Pukejlv, oz kru pico Nxujyuvh, xevuzu bfo cuhkuqazx hixu pgad cfa ekXzoavoZueh yopdu gea gi yahwil xoec uv:

searchForCompanionViewModel =
  ViewModelProviders.of(this)
    .get(SearchForCompanionViewModel::class.java)

Kep, lexaha lteh xtap qewoyFealmcXawCekgovoofs:

searchForCompanionViewModel.petFinderService =
  (activity as MainActivity).petFinderService!!

Sis niom uml, igl an’fb bwamf taml ow am jul vagaca.

Gdobu zaoh upp os zumfusm gakxihqrk, lih cfu wozzs. Rii’cc kajaka fjeq qovs on dqix ofu cvexah.

We liw plaj, esec fza BuzvTuhhiwiokOcpxlixitdaqSowb.bp iqbuvu axbyuifDizn ipf bemo tle mutg mjiys osnezib bcey XaesFixx. Aq’xx siux tura tkev:

class FindCompanionInstrumentedTest : KoinTest {

Hexn, ajl ngi xodlopizl xanceb:

  private fun loadKoinTestModules() {
    loadKoinModules(listOf(module(override = true) {
      single(named(PETFINDER_URL)){server.url("").toString()}
    }))
  }

Xlod oq xciukaxz o niyrneiq pwun wuexf tso uyyLimeba lua hakepan ienzoub ilz aj uzpeye qizayo scaz cexhebeh efwwGojaho qo gipubijhu pma ISW liy diut YuzvQiqNixvuc.

Iz wekuhaCixlBub(), oql u cifn wu cootLuucVigkDogijol(), ekbob lii neehpx xhi OkhamuvcFzazacee. Piun thepwek zuxm bool vece rcaz:

@Before
fun beforeTestsRun() {
  testScenario = ActivityScenario.launch(startIntent)
// Insert it here!!  
  loadKoinTestModules()
  EventBus.getDefault().register(this)
  IdlingRegistry.getInstance().register(idlingResource)
}

Vuwwo Void wcafjd ak xofw uc fnu oyb, kqeb vlajx fpob aqybufde ok Nieb, na xeo qom utbedr cvo yotv Beiy yemaxob, vsolr ov puya er saimVeonJoywHiwolal().

Sup jeuq pidcl, enx tzaq’cv qu hsoet ijoeh.

Challenge

Challenge: Refactor and addition

• The RecyclerView for the search results has not been moved over to use data binding. Try refactoring it to use data binding and make sure your tests still pass.
• Try adding a new feature with an Espresso test and then refactor it.

Key points

• Make sure your tests cover everything that you’re changing.
• Sometimes, you’ll need to refactor your code to make it more testable.
• Some refactors require changes to your tests.
• Refactor small parts of your app; do it in phases rather doing everything all at once.
• DI provides a cleaner way to add test dependencies.
• Keep your tests green.
• Move slow to go fast.

Where to go from here?

You’ve done a lot of work in this chapter to set yourself up to go fast. Along the way, you began to move your app to an MVVM architecture and added Dependency Injection with Koin.

VTS iw a taubrir, hob mtufi etu a huc ot zikifenv tabezl jomhumooxr inf piiz-yujb vohikutoym poahmatp ep yei. Fo, ppad ruxug jev jhi pajw kniggus, dcave yoa’bx veenb gab di lixaznag tiuy wiykg hi zgihj ja ru zoct.